Conditions | 30 |
Paths | 29 |
Total Lines | 244 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 1 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like datasource.js ➔ dataSource often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
1 | import { fromJS } from 'immutable'; |
||
27 | removeRow, |
||
28 | updateRow, |
||
29 | addNewRow, |
||
30 | moveNode, |
||
31 | setTreeNodeVisibility, |
||
32 | saveRow, |
||
33 | sortData, |
||
34 | filterData, |
||
35 | clearFilter |
||
36 | } from './../actionHelpers/datasource'; |
||
37 | |||
38 | const initialState = fromJS({ lastUpdate: generateLastUpdate() }); |
||
39 | |||
40 | export default handleActions({ |
||
41 | [ADD_NEW_ROW]: addNewRow, |
||
42 | [CLEAR_FILTER_LOCAL]: clearFilter, |
||
43 | [DISMISS_EDITOR]: dismissEditor, |
||
44 | [FILTER_DATA]: filterData, |
||
45 | [MOVE_NODE]: moveNode, |
||
46 | [REMOVE_ROW]: removeRow, |
||
47 | [SAVE_ROW]: saveRow, |
||
48 | [SET_DATA]: setData, |
||
49 | [SET_TREE_NODE_VISIBILITY]: setTreeNodeVisibility, |
||
50 | [SET_TREE_DATA_PARTIAL]: setPartialTreeData, |
||
51 | [SORT_DATA]: sortData, |
||
52 | [UPDATE_ROW]: updateRow |
||
53 | }, initialState); |
||
54 |